Solr
  1. Solr
  2. SOLR-2375

Store & Load functionality for Suggester Lookup implementations

    Details

      Description

      Trie-based autocomplete API has two methods, store(File) and load(File) to persist the trie representation on disk, but in the committed code (SOLR-1316) these methods were not implemented. This issue adds an implementation for both TSTLookup and JaspellLookup.

      1. SOLR-2375.patch
        16 kB
        Mark Miller
      2. SOLR-2375.patch
        12 kB
        Andrzej Bialecki
      3. SOLR-2375-2.patch
        16 kB
        Andrzej Bialecki
      4. SOLR-2375-3.patch
        16 kB
        Andrzej Bialecki

        Activity

        Hide
        Andrzej Bialecki added a comment -

        Patch that implements store/load.

        Show
        Andrzej Bialecki added a comment - Patch that implements store/load.
        Hide
        Andrzej Bialecki added a comment -

        Improved patch & unit test. This now actually loads the lookup data if present and if storeDir is defined.

        Show
        Andrzej Bialecki added a comment - Improved patch & unit test. This now actually loads the lookup data if present and if storeDir is defined.
        Hide
        Mark Miller added a comment -

        Couple small changes:

        close DataOutputStream and DataInputStream in JaspellLookup

        replace e.printStackTraces

        Show
        Mark Miller added a comment - Couple small changes: close DataOutputStream and DataInputStream in JaspellLookup replace e.printStackTraces
        Hide
        Andrzej Bialecki added a comment -

        Fix a bug where Integer-s where stored in a tree instead of Float-s.

        If there are no objections I'd like to commit this shortly.

        Show
        Andrzej Bialecki added a comment - Fix a bug where Integer-s where stored in a tree instead of Float-s. If there are no objections I'd like to commit this shortly.
        Hide
        Mark Miller added a comment -

        If there are no objections I'd like to commit this shortly.

        +1 - looks good!

        Show
        Mark Miller added a comment - If there are no objections I'd like to commit this shortly. +1 - looks good!
        Hide
        Andrzej Bialecki added a comment -

        Committed to trunk rev. 1075804 and to branch_3x rev. 1075841.

        Show
        Andrzej Bialecki added a comment - Committed to trunk rev. 1075804 and to branch_3x rev. 1075841.
        Hide
        Robert Muir added a comment -

        Bulk close for 3.2

        Show
        Robert Muir added a comment - Bulk close for 3.2

          People

          • Assignee:
            Andrzej Bialecki
            Reporter:
            Andrzej Bialecki
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development