Solr
  1. Solr
  2. SOLR-2365

DIH should not be in the Solr war

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1
    • Component/s: Build
    • Labels:
      None

      Description

      The DIH has a build.xml that puts itself into the Solr war file. This is the only contrib module that does this, and I don't think it should be this way. Granted there is a small dataimport.jsp file that would be most convenient to remain included, but the jar should not be.

        Activity

        Hide
        Grant Ingersoll added a comment -

        Bulk close for 3.1.0 release

        Show
        Grant Ingersoll added a comment - Bulk close for 3.1.0 release
        Hide
        Yonik Seeley added a comment -

        Committed to trunk and merged back to 3.1

        Show
        Yonik Seeley added a comment - Committed to trunk and merged back to 3.1
        Hide
        Hoss Man added a comment -

        +1

        we need to make sure to call this out at the top of CHANGES.txt so people upgrading from 1.x know they must modify their solrconfig.xml (to add the <lib/ directive) if they use DIH ... but yeah, if it doesn't need to be in hte war for that JSP to work, then let's keep it as an isolated contrib jar.

        Show
        Hoss Man added a comment - +1 we need to make sure to call this out at the top of CHANGES.txt so people upgrading from 1.x know they must modify their solrconfig.xml (to add the <lib/ directive) if they use DIH ... but yeah, if it doesn't need to be in hte war for that JSP to work, then let's keep it as an isolated contrib jar.
        Hide
        Uwe Schindler added a comment -

        +1; who wants to set the touchy fix version?

        Show
        Uwe Schindler added a comment - +1; who wants to set the touchy fix version?
        Hide
        Robert Muir added a comment -

        +1 to fixing all the build/test/documentation/bugs problems we can before the release.

        Show
        Robert Muir added a comment - +1 to fixing all the build/test/documentation/bugs problems we can before the release.
        Hide
        David Smiley added a comment -

        Uwe; are you willing to put fix-for of 3.1 on this or is that a touchy subject? ;-P

        Show
        David Smiley added a comment - Uwe; are you willing to put fix-for of 3.1 on this or is that a touchy subject? ;-P
        Hide
        Uwe Schindler added a comment -

        +1 for remove from war file!

        Show
        Uwe Schindler added a comment - +1 for remove from war file!
        Hide
        Erik Hatcher added a comment -

        Since DIH worked out of the box with Solr 1.4.x, we probably want to keep it that way moving forward (for now). We should put the <lib> directive into Solr's main example solrconfig.xml (just we do with clustering, Solr Cell, etc) also.

        Other than that, no objections to this.

        [tangent, but ideally we can eventually get all Solr UI to be Velocity generated, and plugins can then ship with their own .vm files in the JAR file to add in something like a dataimport.jsp]

        Show
        Erik Hatcher added a comment - Since DIH worked out of the box with Solr 1.4.x, we probably want to keep it that way moving forward (for now). We should put the <lib> directive into Solr's main example solrconfig.xml (just we do with clustering, Solr Cell, etc) also. Other than that, no objections to this. [tangent, but ideally we can eventually get all Solr UI to be Velocity generated, and plugins can then ship with their own .vm files in the JAR file to add in something like a dataimport.jsp]
        Hide
        David Smiley added a comment -

        This patch removes the line in the DIH build.xml that includes its jar file into the war. It makes a simple fix to dataimport.jsp so that it does not have a compile-time dependency on the DIH. And in example-DIH, adds some dih jar file references via <lib> directives.

        Show
        David Smiley added a comment - This patch removes the line in the DIH build.xml that includes its jar file into the war. It makes a simple fix to dataimport.jsp so that it does not have a compile-time dependency on the DIH. And in example-DIH, adds some dih jar file references via <lib> directives.

          People

          • Assignee:
            Unassigned
            Reporter:
            David Smiley
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development