Solr
  1. Solr
  2. SOLR-2296

Upgrade Carrot2 binaries to version 3.4.2

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1, 4.0-ALPHA
    • Component/s: contrib - Clustering
    • Labels:
      None

      Description

      Version 3.4.2 fixes a concurrency bug in Carrot2 that may be causing SOLR-2282. I'll attach patches in a minute.

      1. SOLR-2296-branch_3.1.patch
        2 kB
        Stanislaw Osinski
      2. SOLR-2296-trunk.patch
        2 kB
        Stanislaw Osinski
      3. carrot2-core-3.4.2.jar
        972 kB
        Stanislaw Osinski
      4. carrot2-core-3.4.2-jdk1.5.jar
        912 kB
        Stanislaw Osinski

        Issue Links

          Activity

          Hide
          Stanislaw Osinski added a comment -

          Patches for trunk, branch_3.1 and Carrot2 3.4.2 JAR (BSD License).

          Show
          Stanislaw Osinski added a comment - Patches for trunk, branch_3.1 and Carrot2 3.4.2 JAR (BSD License).
          Hide
          Koji Sekiguchi added a comment -

          Thanks Stanislaw!

          I'll apply the patch and jar, and remove @Ignore from DistributedClusteringComponentTest.

          Show
          Koji Sekiguchi added a comment - Thanks Stanislaw! I'll apply the patch and jar, and remove @Ignore from DistributedClusteringComponentTest.
          Hide
          Koji Sekiguchi added a comment -

          trunk: Committed revision 1052416.
          3x: Committed revision 1052417.

          Let's see how hudson likes these changes.

          Show
          Koji Sekiguchi added a comment - trunk: Committed revision 1052416. 3x: Committed revision 1052417. Let's see how hudson likes these changes.
          Hide
          Koji Sekiguchi added a comment -

          Hmm, seems hudson doesn't like the changes...

          Build: https://hudson.apache.org/hudson/job/Lucene-Solr-tests-only-trunk/2916/

          1 tests failed.
          FAILED: org.apache.solr.handler.clustering.DistributedClusteringComponentTest.testDistribSearch

          Error Message:
          Some threads threw uncaught exceptions!

          Stack Trace:
          junit.framework.AssertionFailedError: Some threads threw uncaught exceptions!
          at org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:1104)
          at org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:1042)
          at org.apache.lucene.util.LuceneTestCase.tearDown(LuceneTestCase.java:499)
          at org.apache.solr.SolrTestCaseJ4.tearDown(SolrTestCaseJ4.java:92)
          at org.apache.solr.BaseDistributedSearchTestCase.tearDown(BaseDistributedSearchTestCase.java:144)

          Show
          Koji Sekiguchi added a comment - Hmm, seems hudson doesn't like the changes... Build: https://hudson.apache.org/hudson/job/Lucene-Solr-tests-only-trunk/2916/ 1 tests failed. FAILED: org.apache.solr.handler.clustering.DistributedClusteringComponentTest.testDistribSearch Error Message: Some threads threw uncaught exceptions! Stack Trace: junit.framework.AssertionFailedError: Some threads threw uncaught exceptions! at org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:1104) at org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:1042) at org.apache.lucene.util.LuceneTestCase.tearDown(LuceneTestCase.java:499) at org.apache.solr.SolrTestCaseJ4.tearDown(SolrTestCaseJ4.java:92) at org.apache.solr.BaseDistributedSearchTestCase.tearDown(BaseDistributedSearchTestCase.java:144)
          Hide
          Koji Sekiguchi added a comment -

          There is compile errors on 3.x:

          Build: https://hudson.apache.org/hudson/job/Lucene-Solr-tests-only-3.x/2890/

          No tests ran.

          Build Log (for compile errors):
          [...truncated 3474 lines...]

          javacc-notice:

          init:

          clover.setup:

          clover.info:
          [echo]
          [echo] Clover not found. Code coverage reports disabled.
          [echo]

          clover:

          common.compile-core:

          compile-core:

          compile-test:
          [javac] Compiling 1 source file to /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/lucene/build/classes/test
          [javac] warning: [path] bad path element "/home/hudson/.ant/lib/xbean.jar": no such file or directory
          [javac] 1 warning

          init:

          clover.setup:

          clover.info:
          [echo]
          [echo] Clover not found. Code coverage reports disabled.
          [echo]

          clover:

          compile-core:

          jar-core:
          [jar] Building jar: /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/lucene/build/contrib/analyzers/stempel/lucene-stempel-3.1-SNAPSHOT.jar

          jar:

          module-jars-to-solr:
          [mkdir] Created dir: /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/contrib/analysis-extras/lucene-libs
          [copy] Copying 3 files to /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/contrib/analysis-extras/lucene-libs

          init:
          [mkdir] Created dir: /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/contrib/analysis-extras/build/classes
          [mkdir] Created dir: /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/build/docs/api

          init-forrest-entities:

          compile-lucene:

          compile-solrj:

          compile:
          [javac] Compiling 3 source files to /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/build/solr
          [javac] warning: [path] bad path element "/home/hudson/.ant/lib/xbean.jar": no such file or directory
          [javac] 1 warning

          compileTests:

          make-manifest:
          [mkdir] Created dir: /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/build/META-INF

          compile:
          [javac] Compiling 8 source files to /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/contrib/analysis-extras/build/classes
          [javac] warning: [path] bad path element "/home/hudson/.ant/lib/xbean.jar": no such file or directory
          [javac] 1 warning

          build:
          [jar] Building jar: /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/contrib/analysis-extras/build/apache-solr-analysis-extras-3.1-SNAPSHOT.jar

          init:
          [mkdir] Created dir: /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/contrib/clustering/build/classes

          init-forrest-entities:

          compile-lucene:

          compile-solrj:

          compile:
          [javac] Compiling 3 source files to /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/build/solr
          [javac] warning: [path] bad path element "/home/hudson/.ant/lib/xbean.jar": no such file or directory
          [javac] 1 warning

          compileTests:

          make-manifest:

          compile:
          [javac] Compiling 8 source files to /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/contrib/clustering/build/classes
          [javac] warning: [path] bad path element "/home/hudson/.ant/lib/xbean.jar": no such file or directory
          [javac] /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/contrib/clustering/src/main/java/org/apache/solr/handler/clustering/carrot2/CarrotClusteringEngine.java:48: cannot access org.carrot2.core.Cluster
          [javac] bad class file: /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/contrib/clustering/lib/carrot2-core-3.4.2.jar(org/carrot2/core/Cluster.class)
          [javac] class file has wrong version 50.0, should be 49.0
          [javac] Please remove or make sure it appears in the correct subdirectory of the classpath.
          [javac] import org.carrot2.core.Cluster;
          [javac] ^
          [javac] 1 error
          [...truncated 12 lines...]

          I think I need to revert the previous commit to stop successive errors from hudson. I'll see the compile error.

          Show
          Koji Sekiguchi added a comment - There is compile errors on 3.x: Build: https://hudson.apache.org/hudson/job/Lucene-Solr-tests-only-3.x/2890/ No tests ran. Build Log (for compile errors): [...truncated 3474 lines...] javacc-notice: init: clover.setup: clover.info: [echo] [echo] Clover not found. Code coverage reports disabled. [echo] clover: common.compile-core: compile-core: compile-test: [javac] Compiling 1 source file to /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/lucene/build/classes/test [javac] warning: [path] bad path element "/home/hudson/.ant/lib/xbean.jar": no such file or directory [javac] 1 warning init: clover.setup: clover.info: [echo] [echo] Clover not found. Code coverage reports disabled. [echo] clover: compile-core: jar-core: [jar] Building jar: /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/lucene/build/contrib/analyzers/stempel/lucene-stempel-3.1-SNAPSHOT.jar jar: module-jars-to-solr: [mkdir] Created dir: /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/contrib/analysis-extras/lucene-libs [copy] Copying 3 files to /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/contrib/analysis-extras/lucene-libs init: [mkdir] Created dir: /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/contrib/analysis-extras/build/classes [mkdir] Created dir: /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/build/docs/api init-forrest-entities: compile-lucene: compile-solrj: compile: [javac] Compiling 3 source files to /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/build/solr [javac] warning: [path] bad path element "/home/hudson/.ant/lib/xbean.jar": no such file or directory [javac] 1 warning compileTests: make-manifest: [mkdir] Created dir: /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/build/META-INF compile: [javac] Compiling 8 source files to /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/contrib/analysis-extras/build/classes [javac] warning: [path] bad path element "/home/hudson/.ant/lib/xbean.jar": no such file or directory [javac] 1 warning build: [jar] Building jar: /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/contrib/analysis-extras/build/apache-solr-analysis-extras-3.1-SNAPSHOT.jar init: [mkdir] Created dir: /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/contrib/clustering/build/classes init-forrest-entities: compile-lucene: compile-solrj: compile: [javac] Compiling 3 source files to /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/build/solr [javac] warning: [path] bad path element "/home/hudson/.ant/lib/xbean.jar": no such file or directory [javac] 1 warning compileTests: make-manifest: compile: [javac] Compiling 8 source files to /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/contrib/clustering/build/classes [javac] warning: [path] bad path element "/home/hudson/.ant/lib/xbean.jar": no such file or directory [javac] /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/contrib/clustering/src/main/java/org/apache/solr/handler/clustering/carrot2/CarrotClusteringEngine.java:48: cannot access org.carrot2.core.Cluster [javac] bad class file: /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/contrib/clustering/lib/carrot2-core-3.4.2.jar(org/carrot2/core/Cluster.class) [javac] class file has wrong version 50.0, should be 49.0 [javac] Please remove or make sure it appears in the correct subdirectory of the classpath. [javac] import org.carrot2.core.Cluster; [javac] ^ [javac] 1 error [...truncated 12 lines...] I think I need to revert the previous commit to stop successive errors from hudson. I'll see the compile error.
          Hide
          Koji Sekiguchi added a comment -

          Stanislaw, can you build carrot2 with Java 1.5?

          MANIFEST@Carrot2 3.4.0
          Manifest-Version: 1.0
          Ant-Version: Apache Ant 1.7.1
          Created-By: 1.5.0_22-b03 (Sun Microsystems Inc.)
          
          MANIFEST@Carrot2 3.4.2
          Manifest-Version: 1.0
          Ant-Version: Apache Ant 1.7.1
          Created-By: 16.3-b01 (Sun Microsystems Inc.)
          
          Show
          Koji Sekiguchi added a comment - Stanislaw, can you build carrot2 with Java 1.5? MANIFEST@Carrot2 3.4.0 Manifest-Version: 1.0 Ant-Version: Apache Ant 1.7.1 Created-By: 1.5.0_22-b03 (Sun Microsystems Inc.) MANIFEST@Carrot2 3.4.2 Manifest-Version: 1.0 Ant-Version: Apache Ant 1.7.1 Created-By: 16.3-b01 (Sun Microsystems Inc.)
          Hide
          Stanislaw Osinski added a comment -

          Oh, sorry, I forgot branch_3.x is Java 1.5. I'll get back with a 1.5 JAR in a while.

          Show
          Stanislaw Osinski added a comment - Oh, sorry, I forgot branch_3.x is Java 1.5. I'll get back with a 1.5 JAR in a while.
          Hide
          Stanislaw Osinski added a comment -

          Carrot2 3.4.2 core JAR compile for JDK 1.5, contrib/clustering compiles fine for me, clustering tests pass too.

          Show
          Stanislaw Osinski added a comment - Carrot2 3.4.2 core JAR compile for JDK 1.5, contrib/clustering compiles fine for me, clustering tests pass too.
          Hide
          Koji Sekiguchi added a comment -

          Thanks, I committed 1.5 jar file.

          trunk: Committed revision 1057149.
          3x: Committed revision 1057150.

          Unfortunately, I think 3.4.2 jar doesn't solve SOLR-2282 test issue (see above error on trunk) but I'm marking this issue as resolved.
          I think I look at the test error in SOLR-2282.

          Show
          Koji Sekiguchi added a comment - Thanks, I committed 1.5 jar file. trunk: Committed revision 1057149. 3x: Committed revision 1057150. Unfortunately, I think 3.4.2 jar doesn't solve SOLR-2282 test issue (see above error on trunk) but I'm marking this issue as resolved. I think I look at the test error in SOLR-2282 .
          Hide
          Grant Ingersoll added a comment -

          Bulk close for 3.1.0 release

          Show
          Grant Ingersoll added a comment - Bulk close for 3.1.0 release

            People

            • Assignee:
              Koji Sekiguchi
              Reporter:
              Stanislaw Osinski
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development