[SOLR-2288] clean up compiler warnings

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0
• Assignee: Chris M. Hostetter
• Reporter: Chris M. Hostetter
• Created: 15/Dec/10 01:02
• Updated: 22/May/17 17:14
• Resolved: 22/May/17 17:14

Description

there's a ton of compiler warning in the solr tree, and it's high time we cleaned them up, or annotate them to be suppressed so we can start making a bigger stink when/if code is added to the tree thta produces warnings (we'll never do a good job of noticing new warnings when we have ~175 existing ones)

Using this issue to track related commits

The goal of this issue should not be to change any functionality or APIs, just deal with each warning in the most appropriate way;

• fix generic declarations
• add SuppressWarning anotation if it's safe in context

Issue Links

• is related to: SOLR-2292 Lock down NamedList API, remove inefficent and esoteric methods