[SOLR-2046] add a function to set curl_url in scripts-util

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.4.1
• Fix Version/s: 3.1, 4.0-ALPHA
• Component/s: replication (scripts)
• Assignee: Koji Sekiguchi
• Reporter: Koji Sekiguchi
• Created: 14/Aug/10 02:12
• Updated: 30/Mar/11 15:45
• Resolved: 27/Aug/10 14:40

Description

abc/abo/commit/optimize/readercycle scripts have the following identical snippet to set curl_url:

if [[ -n ${solr_url} ]]
then
  curl_url=${solr_url}
else
  if [[ -z ${solr_port} ]]
  then
    echo "Solr port number missing in $confFile or command line."
    echo "$USAGE"
    exit 1
  fi

  # use default hostname if not specified
  if [[ -z ${solr_hostname} ]]
  then
    solr_hostname=localhost
  fi

  # use default webapp name if not specified
  if [[ -z ${webapp_name} ]]
  then
    webapp_name=solr
  fi
  curl_url=http://${solr_hostname}:${solr_port}/${webapp_name}/update
fi

I think it should be moved to scripts-util in order to improve readability/maintainability.