[SOLR-2003] report errors for wrongly-encoded files in ResourceLoader.getLines()

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.1, 4.0-ALPHA
• Assignee: Robert Muir
• Reporter: Robert Muir
• Created: 14/Jul/10 16:32
• Updated: 30/Mar/11 15:45
• Resolved: 19/Jul/10 13:32

Description

ResourceLoader is used to load things like stopwords and synonyms files, but it uses the default 'Charset' argument for this.

when you open an InputStream with a Charset, you get:

decoder = charset.newDecoder().onMalformedInput(
    CodingErrorAction.REPLACE).onUnmappableCharacter(
    CodingErrorAction.REPLACE);

For cases like malformed encoded stopwords and synonyms files, I think its more helpful to use CodingErrorAction.REPORT than to silently replace with a replacement char. Then the user gets an exception.

See: http://www.lucidimagination.com/search/document/1e50cb0992727fa1/foreign_characters_question