[SOLR-1990] blockUntilFinished() is called in StreamingUpdateSolrServer more often then it should

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 1.4.1
• Fix Version/s: 4.6
• Component/s: clients - java
• Assignee: Unassigned
• Reporter: ofer fort
• Created: 08/Jul/10 12:23
• Updated: 27/Sep/24 02:59
• Resolved: 27/Sep/24 02:59

Description

in the StreamingUpdateSolrServer .request() it identifies a commit/optimize request by having no document...

    // this happens for commit...
    if( req.getDocuments()==null || req.getDocuments().isEmpty() ) {
      blockUntilFinished();

...but there are other situations where an UpdateRequest will nave no documents (delete, updates using stream.url or stream.file, etc...)

Issue Links

• is fixed by: SOLR-5465 SolrCmdDistributor retry logic has a race bug.
• is fixed by: SOLR-5760 ConcurrentUpdateSolrServer has a blockUntilFinished call when streamDeletes is true that should be tucked into the if statement below it.