Solr
  1. Solr
  2. SOLR-1792

Document peculiar behavior of TestHarness.LocalRequestFactory

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0, 1.2, 1.3, 1.4
    • Fix Version/s: 1.5, 3.1, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      While working on a test case, i realized that due to method evolution, TestHarness.LocalRequestFactory.makeRequest has some really odd behavior that results in the "defaults" the factory was configured with being ignored when the method is called with multiple varargs.

      I spent some time attempting to "fix" this by adding the defaults to the end of the params, but then discovered that this breaks existing tests because the LRF defaults take precedence over defaults that may be hardcoded into the solrconfig.xml. The internal test might be changed to work arround this, but i didn't want to risk breaking tests for users who might be using TestHarness directly.

      So this bug is just to track improving the documentation of what exactly LRF.makeRequest does with it's input

        Activity

        Hide
        Hoss Man added a comment -

        patch ... i would have already committed this but SVN seems to be down.

        Show
        Hoss Man added a comment - patch ... i would have already committed this but SVN seems to be down.
        Hide
        Hoss Man added a comment -

        Committed revision 915637.

        Show
        Hoss Man added a comment - Committed revision 915637.
        Hide
        Hoss Man added a comment -

        Correcting Fix Version based on CHANGES.txt, see this thread for more details...

        http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E

        Show
        Hoss Man added a comment - Correcting Fix Version based on CHANGES.txt, see this thread for more details... http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E
        Hide
        Grant Ingersoll added a comment -

        Bulk close for 3.1.0 release

        Show
        Grant Ingersoll added a comment - Bulk close for 3.1.0 release

          People

          • Assignee:
            Hoss Man
            Reporter:
            Hoss Man
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development