[SOLR-17488] CLI: Resolve -d conflicts

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 9.7, 9.6.1
• Fix Version/s: 9.8
• Component/s: cli
• Labels: cli pull-request-available
• Assignee: Eric Pugh
• Reporter: Christos Malliaridis
• Created: 10/Oct/24 17:50
• Updated: 25/Oct/24 11:05
• Resolved: 25/Oct/24 11:05

Description

The CLI flag -d is currently used in four options:

• conf-dir for providing the configuration directory in CreateTool, ConfigSetDownloadTool, ConfigSetUploadTool, ZKCLI
• delete-config (with argument) for deleting configurations together with collections in DeleteTool, defualts to true
• server-dir for defining the Solr root / server directory in RunExampleTool
• delay for delaying recursive posts in PostTool

Proposed Resolution

In order to avoid confusion of the -d flag, the following changes are proposed:

• keep -d for conf-dir in CreateTool, ConfigSetDownloadTool, ConfigSetUploadTool, ZKCLI
• Deprecated (9.8) and remove (10.0) the delete-config option by replacing it with keep (--keep without arguments) for simplifying and improving user experience and avoid conflict of -d. "--keep" should behave equivalent to "--delete-config false".
• Deprecate (9.8) and remove (10.0) -d for server-dir in RunExmapleTool. Note that --server-dir may be removed or renamed to use better wording in the future.
• Support --server-dir in bin/solr and if necessary bin/solr.cmd in version 9.8 and 10.0
• Deprecate (9.8) and remove (10.0) -d for delay in PostTool to avoid any confusion with conf-dir.

Issue Links

• links to: GitHub Pull Request #2754
• links to: GitHub Pull Request #2760