Solr
  1. Solr
  2. SOLR-1740

ShingleFilterFactory improvements

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1, 4.0-ALPHA
    • Component/s: Schema and Analysis
    • Labels:
      None

      Description

      ShingleFilterFactory should allow specification of minimum shingle size (in addition to maximum shingle size), as well as the separator to use between tokens. These are implemented at LUCENE-2218. The attached patch allows ShingleFilterFactory to accept configuration of these items, and includes tests against the new functionality in TestShingleFilterFactory.

      Solr will have to upgrade to lucene-analyzers-3.1-dev.jar before the attached patch will apply.

      1. SOLR-1740.patch
        9 kB
        Steve Rowe
      2. SOLR-1740.patch
        9 kB
        Robert Muir

        Issue Links

          Activity

          Hide
          Steve Rowe added a comment -

          All patched TestShingleFilterFactory tests pass when I substitute a LUCENE-2218-patched lucene-analyzers-3.1-dev.jar in solr/lib/ for lucene-analyzers-2.9.1-dev.jar.

          Show
          Steve Rowe added a comment - All patched TestShingleFilterFactory tests pass when I substitute a LUCENE-2218 -patched lucene-analyzers-3.1-dev.jar in solr/lib/ for lucene-analyzers-2.9.1-dev.jar.
          Hide
          Robert Muir added a comment -

          Now that we are on Lucene 3.1, it seems like it would be useful to add these new capabilities to the factory?

          Show
          Robert Muir added a comment - Now that we are on Lucene 3.1, it seems like it would be useful to add these new capabilities to the factory?
          Hide
          Robert Muir added a comment -

          Steven's patch, synced to trunk.

          I plan to commit shortly, thanks for the configuration tests Steven.

          Show
          Robert Muir added a comment - Steven's patch, synced to trunk. I plan to commit shortly, thanks for the configuration tests Steven.
          Hide
          Robert Muir added a comment -

          Committed revision 930163. Thanks Steven!

          Show
          Robert Muir added a comment - Committed revision 930163. Thanks Steven!
          Hide
          Steve Rowe added a comment -

          Thank you, Robert.

          Show
          Steve Rowe added a comment - Thank you, Robert.
          Hide
          Hoss Man added a comment -

          Correcting Fix Version based on CHANGES.txt, see this thread for more details...

          http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E

          Show
          Hoss Man added a comment - Correcting Fix Version based on CHANGES.txt, see this thread for more details... http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E
          Hide
          Grant Ingersoll added a comment -

          Bulk close for 3.1.0 release

          Show
          Grant Ingersoll added a comment - Bulk close for 3.1.0 release

            People

            • Assignee:
              Robert Muir
              Reporter:
              Steve Rowe
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development