Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-17349

SolrDocumentFetcher should always skip lazy field loading overhead if documentCache==null

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • main (10.0), 8.11.3, 9.6.1
    • 9.7
    • None
    • None

    Description

      SolrDocumentFetcher currently still adds some overhead for lazy loading of stored fields, even when there is no documentCache, in which case iiuc lazy field loading should be irrelevant.

      I stumbled across this while looking into a problem reported on the solr-users list. The connection to the reported problem is still a bit mysterious (there are as-yet-unexplained magic numbers involved), but in some cases at least, the reported performance degradation was quite significant, and the reported workaround circumstantially supports this change as a possible fix.

      I think this change is a positive one regardless; and if it ends up fixing the reported issue, so much the better!

      Attachments

        Activity

          People

            magibney Michael Gibney
            magibney Michael Gibney
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 0.5h
                0.5h