[SOLR-17349] SolrDocumentFetcher should always skip lazy field loading overhead if documentCache==null

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: main (10.0), 8.11.3, 9.6.1
• Fix Version/s: 9.7
• Assignee: Michael Gibney
• Reporter: Michael Gibney
• Created: 26/Jun/24 01:55
• Updated: 16/Jul/24 20:28
• Resolved: 27/Jun/24 02:36

Description

SolrDocumentFetcher currently still adds some overhead for lazy loading of stored fields, even when there is no documentCache, in which case iiuc lazy field loading should be irrelevant.

I stumbled across this while looking into a problem reported on the solr-users list. The connection to the reported problem is still a bit mysterious (there are as-yet-unexplained magic numbers involved), but in some cases at least, the reported performance degradation was quite significant, and the reported workaround circumstantially supports this change as a possible fix.

I think this change is a positive one regardless; and if it ends up fixing the reported issue, so much the better!

Issue Links

• links to: GitHub Pull Request #2535
• links to: GitHub Pull Request #2535
• links to: GitHub Pull Request #2551