[SOLR-17326] Wrong class resolution in generated API response classes

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 8.11.3, 9.6.1
• Fix Version/s: main (10.0), 9.7
• Component/s: SolrJ
• Labels: V2 mustache solrj
• Assignee: Jason Gerlowski
• Reporter: Christos Malliaridis
• Created: 09/Jun/24 03:27
• Updated: 25/Oct/24 17:18
• Resolved: 12/Jun/24 09:59

Description

When a naming conflict occurs between the response class and the return type (API model) included in the response of the v2 API, the java-template/api.mustache template will use the response class as return type and ignore the API model. This results in missing fields and parsing errors when calling JacksonParsingResponse.getParsed().

The affected response classes are:

• CoreSnapshotsApi.DeleteSnapshotResponse
• CollectionSnapshotsApi.CreateCollectionSnapshotResponse
• CollectionSnapshotsApi.DeleteCollectionSnapshotResponse
• CollectionsApi.ListCollectionsResponse
• AliasPropertiesApi.GetAllAliasPropertiesResponse
• AliasPropertiesApi.GetAliasPropertyResponse
• AliasesApi.GetAliasByNameResponse

All above classes have the same name as their corresponding return type and differ only in the package name. The generated classes therefore references the response classes and not the API models from org.apache.solr.client.api.model in the generic type.

In order to use the information from the responses custom code that bypasses JacksonParsingresponse.getParsed() is required, otherwise parsing errors may occur.

Issue Links

• links to: GitHub Pull Request #2510