Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-17323

Fix potential ConcurrentModificationException on CachingDirectoryFactory.close()

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 9.6
    • 9.7
    • None
    • None

    Description

      While working on SOLR-16962, this CI run encountered a ConcurrentModificationException on CachingDirectoryFactory.close().

      It's unclear to me whether this issue existed before 9.6, but it may at least have been exacerbated by SOLR-16866 (since previously the directory-removal-reordering logic wasn't doing much of anything).

      In any case, the fix is straightforward. I'm not aware of this issue ever hitting in the wild, fwiw; and if it did, I'm not sure how much of a problem it would be, given that it would hit only during DirectoryFactory.close() (at which point things are shutting down anyway).

      Attachments

        Issue Links

          Activity

            Commit 4d9a0b78d0b40693ee2c50edfa938750aa111d4b in solr's branch refs/heads/main from Michael Gibney
            [ https://gitbox.apache.org/repos/asf?p=solr.git;h=4d9a0b78d0b ]

            SOLR-17323: Fix potential ConcurrentModificationException on CachingDirectoryFactory.close() (#2505)

            jira-bot ASF subversion and git services added a comment - Commit 4d9a0b78d0b40693ee2c50edfa938750aa111d4b in solr's branch refs/heads/main from Michael Gibney [ https://gitbox.apache.org/repos/asf?p=solr.git;h=4d9a0b78d0b ] SOLR-17323 : Fix potential ConcurrentModificationException on CachingDirectoryFactory.close() (#2505)

            Commit 0cdc4b4abeb547ce285ed3ff9356a868f0fde121 in solr's branch refs/heads/branch_9x from Michael Gibney
            [ https://gitbox.apache.org/repos/asf?p=solr.git;h=0cdc4b4abeb ]

            SOLR-17323: Fix potential ConcurrentModificationException on CachingDirectoryFactory.close() (#2505)

            (cherry picked from commit 4d9a0b78d0b40693ee2c50edfa938750aa111d4b)

            jira-bot ASF subversion and git services added a comment - Commit 0cdc4b4abeb547ce285ed3ff9356a868f0fde121 in solr's branch refs/heads/branch_9x from Michael Gibney [ https://gitbox.apache.org/repos/asf?p=solr.git;h=0cdc4b4abeb ] SOLR-17323 : Fix potential ConcurrentModificationException on CachingDirectoryFactory.close() (#2505) (cherry picked from commit 4d9a0b78d0b40693ee2c50edfa938750aa111d4b)
            anshum Anshum Gupta added a comment -

            Closing after the 9.7.0 release

            anshum Anshum Gupta added a comment - Closing after the 9.7.0 release

            People

              magibney Michael Gibney
              magibney Michael Gibney
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m