Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-17189

DockMakerTest.testRealisticUnicode fails from whitespace assumption

    XMLWordPrintableJSON

Details

    • Test
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 9.6
    • benchmarks
    • None

    Description

      DockMakerTest.testRealisticUnicode fails 1-2% of the time – link.

      java.lang.AssertionError: expected:<6> but was:<7>
      at __randomizedtesting.SeedInfo.seed([C5136F274AFF3ADD:95FFEBF499446D74]:0)
      •••
      at org.apache.solr.bench.DockMakerTest.testRealisticUnicode(DockMakerTest.java:189)

      It seems clear it's because it assumes that the "realistic unicode" chars won't match the regexp: \s. A single space char is used to join the words but maybe this or other whitespace chars are in those unicode codepoint blocks.

      Additionally, it's frustrating that this particular benchmark framework doesn't honor tests.seed in its generation of random data and thus it's hard to reproduce the failure. That ought to be fixed as well.

      Attachments

        Issue Links

          Activity

            People

              dsmiley David Smiley
              dsmiley David Smiley
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h
                  1h