[SOLR-17119] Exception swallowing in ContainerPluginsApi causes some config validation errors to be ignored

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 9.4
• Fix Version/s: 9.6
• Component/s: Plugin system, v2 API
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Yohann Callea
• Created: 17/Jan/24 14:39
• Updated: 4 days ago 19:22
• Resolved: 24/Jan/24 18:00

Description

When registering a ConfigurablePlugin through the /cluster/plugin API using the V2Request client, exceptions raised within the void configure(T cfg) method are swallowed in ContainerPluginsApi.

This behavior can be troublesome as the exceptions raised in the configure(...) method are usually validation errors on the configuration to be applied, which are therefore ignored and allow for invalid plugin configuration to become effective.

I proposed a change in apache/solr#2202 to remediate this issue along with a test to illustrate the scenario and validate the fix.

Issue Links

• links to: apache/solr#2202
• links to: GitHub Pull Request #2202