[SOLR-16983] ObjectReleaseTracker completely useless in all SolrTestCaseJ4 based tests - masking unclosed InputStream in some SolrStream usecases

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: main (10.0), 9.4
• Assignee: Chris M. Hostetter
• Reporter: Chris M. Hostetter
• Created: 15/Sep/23 23:07
• Updated: 15/Oct/23 20:13
• Resolved: 21/Sep/23 22:55

Description

NOTE: This was masking a real bug in SolrStream

Fixing tests that fialed while working on this bug lead me to discover that some usages of SolrStream weren't closing their TupleStreamParser which could result in unclosed InputStream (returned from the underlying HTTP client)
 

SolrTestCase has a @ClassRule named solrClassRules which calls ObjectReleaseTracker.clearObjectTrackerAndCheckEmpty() in it's afterIfSuccessful() method to ensure that any objects which use ObjectReleaseTracker are correctly released (ie: closed)

...BUT...

SolrTestCaseJ4 has an @AfterClass method named teardownTestCases() which calls ObjectReleaseTracker.clear() before the afterIfSuccessful() method of it's parent class's solrClassRules gets to run.

... Which means that ObjectReleaseTracker is completley useless in every test that descends from SolrTestCaseJ4.

 

Issue Links

• relates to: SOLR-16992 Non-reproducible StreamingTest failures -- suggests CloudSolrStream concurency race condition