Solr
  1. Solr
  2. SOLR-1661

Remove adminCore from CoreContainer

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.5, 3.1, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      we have deprecated the admin core concept as a part of SOLR-1121. It can be removed completely now.

      1. SOLR-1661.patch
        3 kB
        Noble Paul
      2. SOLR-1661.patch
        3 kB
        Noble Paul

        Activity

        Hide
        Noble Paul added a comment -

        I plan to commit this soon

        Show
        Noble Paul added a comment - I plan to commit this soon
        Hide
        Noble Paul added a comment -

        committed r893411

        Show
        Noble Paul added a comment - committed r893411
        Hide
        Gunnar Wagenknecht added a comment - - edited

        What's the recommended migration strategy? I currently use the following code for programatically creating new cores.

        final CoreContainer coreContainer = ...
        final SolrCore adminCore = coreContainer.getAdminCore();
        try {
          final EmbeddedSolrServer adminServer = new EmbeddedSolrServer(coreContainer, adminCore.getName());
          CoreAdminRequest.createCore("mycore", "mycore", adminServer);
        } finally {
          adminCore.close();
        }
        

        Wasn't CoreContainer API? Does this mean that the next release will be Solr 2.0?

        Show
        Gunnar Wagenknecht added a comment - - edited What's the recommended migration strategy? I currently use the following code for programatically creating new cores. final CoreContainer coreContainer = ... final SolrCore adminCore = coreContainer.getAdminCore(); try { final EmbeddedSolrServer adminServer = new EmbeddedSolrServer(coreContainer, adminCore.getName()); CoreAdminRequest.createCore( "mycore" , "mycore" , adminServer); } finally { adminCore.close(); } Wasn't CoreContainer API? Does this mean that the next release will be Solr 2.0?
        Hide
        Noble Paul added a comment - - edited

        The usage is incorrect.

        The second parameter for the EmbeddedSolrServer is not the adminCore name. you can pass in the core on which you wish to fire the queries . So for single core it can be null

        For CoreAdminRequest, a core is not required anymore . Just pass in any known core name to create the EmbeddedSolrServer

        Show
        Noble Paul added a comment - - edited The usage is incorrect. The second parameter for the EmbeddedSolrServer is not the adminCore name. you can pass in the core on which you wish to fire the queries . So for single core it can be null For CoreAdminRequest, a core is not required anymore . Just pass in any known core name to create the EmbeddedSolrServer
        Hide
        Hoss Man added a comment -

        Correcting Fix Version based on CHANGES.txt, see this thread for more details...

        http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E

        Show
        Hoss Man added a comment - Correcting Fix Version based on CHANGES.txt, see this thread for more details... http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E
        Hide
        Grant Ingersoll added a comment -

        Bulk close for 3.1.0 release

        Show
        Grant Ingersoll added a comment - Bulk close for 3.1.0 release

          People

          • Assignee:
            Noble Paul
            Reporter:
            Noble Paul
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development