[SOLR-16457] solr.data.home should not be set to empty string in bin/solr

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 9.0, 9.1
• Fix Version/s: main (10.0), 9.2
• Component/s: cli
• Assignee: Kevin Risden
• Reporter: Kevin Risden
• Created: 11/Oct/22 16:47
• Updated: 03/Apr/23 16:27
• Resolved: 10/Jan/23 19:32

Description

solr.data.home should not be set to empty string in bin/solr since that causes the security.policy to be more wide open than it should.

solr.cmd does NOT have the same issue since it explicitly checks the case of empty SOLR_DATA_HOME before adding it. https://github.com/apache/solr/blob/main/solr/bin/solr.cmd#L1342

Issue Links

• is related to: SOLR-16734 SOLR_DATA_HOME is only honored in verbode mode
• relates to: SOLR-16433 Security Manager prevents Solr SQL from working
• links to: GitHub Pull Request #1066
• links to: GitHub Pull Request #1165
• links to: GitHub Pull Request #1282
• links to: GitHub Pull Request #1346