Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-16427

Evaluate and fix errorprone rules

Attach filesAttach ScreenshotAdd voteVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Task
    • Status: Patch Available
    • Major
    • Resolution: Unresolved
    • None
    • None
    • Build
    • None

    Description

      Errorprone has many rules and there are a bunch that are disabled in Solr. Some make sense to leave disabled. Others are just disabled because they weren't evaluated.

      See https://github.com/apache/solr/blob/main/gradle/validation/error-prone.gradle

      This was previously done for some rules in SOLR-15908 and SOLR-15613. This relates to SOLR-16364

      Attachments

        Issue Links

        causes

        Bug - A problem which impairs or prevents the functions of the product. SOLR-16511 testBackupIncremental fails with ArrayIndexOutOfBoundsException

        • Major - Major loss of function.
        • Closed
        is related to

        Improvement - An improvement or enhancement to an existing feature or task. SOLR-16222 Address Intellij WARNINGS in Test Code

        • Minor - Minor loss of function, or other problem where easy workaround is present.
        • Open
        relates to

        Sub-task - The sub-task of the issue SOLR-16364 Evaluate using a shared Inspection Profile in IntelliJ

        • Minor - Minor loss of function, or other problem where easy workaround is present.
        • Resolved

        Task - A task that needs to be done. SOLR-15908 Document or fix error-prone patterns relating to tests

        • Major - Major loss of function.
        • Closed

        Task - A task that needs to be done. SOLR-15613 Address error-prone URLEqualsHashCode warning

        • Minor - Minor loss of function, or other problem where easy workaround is present.
        • Closed
        links to

        Web Link GitHub Pull Request #1037

        Web Link GitHub Pull Request #1039

        Web Link GitHub Pull Request #1116

        Web Link GitHub Pull Request #1128

        Web Link GitHub Pull Request #1407

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            krisden Kevin Risden
            krisden Kevin Risden
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 9.5h
                9.5h

                Slack

                  Issue deployment