[SOLR-16427] Evaluate and fix errorprone rules

• Type: Task
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Component/s: Build
• Assignee: Kevin Risden
• Reporter: Kevin Risden
• Created: 22/Sep/22 14:20
• Updated: 02/Apr/23 14:12

Description

Errorprone has many rules and there are a bunch that are disabled in Solr. Some make sense to leave disabled. Others are just disabled because they weren't evaluated.

See https://github.com/apache/solr/blob/main/gradle/validation/error-prone.gradle

This was previously done for some rules in SOLR-15908 and SOLR-15613. This relates to SOLR-16364

Issue Links

• causes: SOLR-16511 testBackupIncremental fails with ArrayIndexOutOfBoundsException
• is related to: SOLR-16222 Address Intellij WARNINGS in Test Code
• relates to: SOLR-16364 Evaluate using a shared Inspection Profile in IntelliJ
• relates to: SOLR-15908 Document or fix error-prone patterns relating to tests
• relates to: SOLR-15613 Address error-prone URLEqualsHashCode warning
• links to: GitHub Pull Request #1037
• links to: GitHub Pull Request #1039
• links to: GitHub Pull Request #1116
• links to: GitHub Pull Request #1128
• links to: GitHub Pull Request #1407