[SOLR-16368] Refactoring: Use SolrClient type instead of overly specific subclasses

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: main (10.0), 9.2
• Assignee: Eric Pugh
• Reporter: David Smiley
• Created: 01/Sep/22 13:50
• Updated: 27/Mar/23 18:04
• Resolved: 26/Oct/22 13:04

Description

There are many references to a specific SolrClient subclass that could simply refer to SolrClient generally, or perhaps CloudSolrClient. This impedes switching/migrating to different SolrClient implementations. A similar example: we know it's a bad practice to declare a List as ArrayList even when it is one; the idea here with SolrClient is the same.

And furthermore, often times "var solrClient = ..." (or even "var solr = ...") is totally adequate in the Solr codebase within a method because the variable name adequately communicates the type. These sorts of changes should happen first, and then weaken type references in APIs.

Issue Links

• is required by: SOLR-16367 Umbrella: Migrate away from Apache HttpClient.
• relates to: SOLR-16498 Tests need the URL from a SolrClient; don't require legacy clients
• links to: GitHub Pull Request #1012
• links to: GitHub Pull Request #1158