[SOLR-1624] Highlighter bug with MultiValued field + TermPositions optimization

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4
• Fix Version/s: 1.5, 3.1, 4.0-ALPHA
• Component/s: highlighter
• Assignee: Unassigned
• Reporter: Chris Harris
• Created: 04/Dec/09 21:52
• Updated: 30/Mar/11 15:45
• Resolved: 07/Dec/09 19:25

Description

When TermPositions are stored, then DefaultSolrHighlighter.doHighlighting(DocList docs, Query query, SolrQueryRequest req, String[] defaultFields) currently initializes tstream only for the first value of a multi-valued field. (Subsequent times through the loop reinitialization is preempted by tots being non-null.) This means that the 2nd/3rd/etc. values are not considered for highlighting purposes, resulting in missed highlights.

I'm attaching a patch with a test case to demonstrate the problem (testTermVecMultiValuedHighlight2), as well as a proposed fix. All highlighter tests pass with this applied. The patch should apply cleanly against the latest trunk.