[SOLR-16167] Review static initializers that reference subclasses

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: main (10.0)
• Assignee: Unassigned
• Reporter: Michael Gibney
• Created: 25/Apr/22 15:06
• Updated: 08/Mar/23 21:19

Description

More general follow-up to SOLR-16165.

There is the potential for classloading deadlock in the case where static initializers reference a subclass.

This issue could cover 1 or 2 things:

1. Fix existing issues
2. Add a build check to prevent such issues from being introduced in the future

Fixing existing issues should be relatively straightforward, once we're specifically looking for them. "in the wild" these are problematic enough that it's probably worth just fixing all such issues whether or not they manifest as deadlock in practice.

It would be great if we could port/modify/leverage an existing implementation that already checks for this and have it apply automatically in the build, unless this approach proves impractical.

Issue Links

• is related to: SOLR-15254 Random deadlock during cores initialization
• is related to: SOLR-16165 Deadlock in SlotAcc initialization
• supercedes: SOLR-15254 Random deadlock during cores initialization