[SOLR-16065] Run checkIfIamStillLeader outside of a Thread in the overseer

• Type: Sub-task
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: Houston Putman
• Created: 01/Mar/22 20:23
• Updated: 01/Mar/22 20:24

Description

Currently at the end of Overseer.run(), a thread is created to continuously check if the overseer is still the leader.

//do this in a separate thread because any wait is interrupted in this main thread
new Thread(this::checkIfIamStillLeader, "OverseerExitThread").start();

I'm currently unsure as to why the check needs to ignore any interruptions, but this is causing failing tests due to this thread being leaked.

Issue Links

• breaks: SOLR-16046 Thread leak in TestLeaderElectionZkExpiry