[SOLR-15966] Get rid of WEB-INF/lib/jsr305-3.0.2.jar

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 9.0
• Component/s: Build
• Assignee: Jan Høydahl
• Reporter: Jan Høydahl
• Created: 31/Jan/22 21:21
• Updated: 12/May/22 00:35
• Resolved: 02/Feb/22 11:02

Description

Smoke tester found this

RuntimeError: JAR file "/private/tmp/smoke_solr_9.0.0_96bb28303424e40d1db18a9904729521d12926dc_6/unpack/solr-9.0.0/server/solr-webapp/webapp/WEB-INF/lib/jsr305-3.0.2.jar" contains sheisty class "javax/annotation/CheckForNull.class" 

Our build includes the jar as a depenendcy of google libs

com.google.code.findbugs:annotations:3.0.1 (1 constraints: 0605fb35)
com.google.code.findbugs:jsr305:3.0.2 (9 constraints: 057f5545) 

./gradlew why --hash 057f5545
...

> Task :why
com.google.code.findbugs:jsr305:3.0.2
        com.google.api:api-common -> 3.0.2
        com.google.api:gax -> 3.0.2
        com.google.auth:google-auth-library-oauth2-http -> 3.0.2
        com.google.cloud:google-cloud-core -> 3.0.2
        com.google.cloud:google-cloud-nio -> 3.0.2
        com.google.cloud:google-cloud-storage -> 3.0.2
        com.google.code.findbugs:annotations -> 3.0.1
        com.google.guava:guava -> 3.0.2
        com.google.http-client:google-http-client -> 3.0.2 

Although it is "safe" to include this with Java11 (the package javax.annotations is not defined in JDK 11), it is better not to ship it since it is not needed runtime.

Also, the {{gcs-repository]} module has this one

RuntimeError: JAR file "/private/tmp/smoke_solr_9.0.0_96bb28303424e40d1db18a9904729521d12926dc_7/unpack/solr-9.0.0/modules/gcs-repository/lib/javax.annotation-api-1.3.2.jar" contains sheisty class "javax/annotation/sql/DataSourceDefinitions.class"

Issue Links

• links to: GitHub Pull Request #582