[SOLR-15958] review FilterFeatureScorer delegation logic w.r.t. Scorable

• Type: Task
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: contrib - LTR
• Assignee: Christine Poerschke
• Reporter: Christine Poerschke
• Created: 26/Jan/22 18:03
• Updated: 26/Jan/22 18:12

Description

I noticed that LUCENE-9537 changed TestFeature so that FilterFeatureScorer does not delegate the smoothingScore method, that surprised me.

Looking further, prior to that, setMinCompetitiveScore and getChildren are also not delegated (but the test coverage does not capture that as intentional).

From SOLR-15071 we know that delegation/non-delegation bugs can be quite subtle.

This ticket is to consider the logic and to capture the intended behaviour in the test coverage.

Issue Links

• is related to: SOLR-15071 Bug on LTR when using solr 8.6.3 - index out of bounds DisiPriorityQueue.add(DisiPriorityQueue.java:102)
• is related to: LUCENE-9537 Add Indri Search Engine Functionality to Lucene
• links to: GitHub Pull Request #567