[SOLR-15910] Upgrade semver library to fix versioning constraint bugs in the PackageManager

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 9.0, 9.1
• Fix Version/s: main (10.0), 9.2
• Component/s: Package Manager
• Assignee: Kevin Risden
• Reporter: Houston Putman
• Created: 11/Jan/22 22:30
• Updated: 27/Mar/23 18:04
• Resolved: 15/Oct/22 20:59

Description

We are using a semver libary currently that doesn't support features in the test ("8 - 9"), and also hasn't been updated in 7 years. https://github.com/zafarkhaja/jsemver

Jan also found a bug in the way that it's toString() method works.

We need to use a more modern library: https://github.com/vdurmont/semver4j

However there is a small but critical bug in their NPM version comparing: https://github.com/vdurmont/semver4j/issues/48

The library hasn't been updated in 2 years, so it looks like we will need to fork this unfortunately to fix the bugs. If anyone can find another library that we can use, I'd be happy to use that instead, but I wasn't able to find anything after looking for quite a while.

Issue Links

• causes: SOLR-16467 Upgrade semver4j to 2.2.0 to fix failures with some locales
• fixes: SOLR-15902 PackageManagerCLITest.testPackageManager fails on main
• links to: GitHub Pull Request #515
• links to: GitHub Pull Request #1077