[SOLR-15711] Fix GCSRepository to follow BackupRepository.createDirectory API contract

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 9.0
• Component/s: contrib - GCS Repository
• Assignee: Houston Putman
• Reporter: Houston Putman
• Created: 21/Oct/21 19:48
• Updated: 12/May/22 00:26
• Resolved: 10/Nov/21 16:13

Description

Noticed when doing work for SOLR-15702.

The Solr backup commands call BackupRepository.createDirectory at various times, while also checking that the same directory exists (via pathExists) at different times. The issue here is that during the distributed Backup commands, (sent to different nodes for each shard), one node might be at the part of the backup where it is calling createDirectory when another node is calling pathExists for the same directory.

When following the BackupRepository API Spec correctly, this should not be an issue because createDirectory should be a no-op when the directory already exists. However GCSRepository does not make this check before creating the directory. This should be an easy fix.

Issue Links

• relates to: SOLR-15702 Stabilize S3 Tests - Fix S3Repository to follow BackupRepository.createDirectory API contract
• links to: GitHub Pull Request #373