Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-15711

Fix GCSRepository to follow BackupRepository.createDirectory API contract

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 9.0
    • None

    Description

      Noticed when doing work for SOLR-15702.

      The Solr backup commands call BackupRepository.createDirectory at various times, while also checking that the same directory exists (via pathExists) at different times. The issue here is that during the distributed Backup commands, (sent to different nodes for each shard), one node might be at the part of the backup where it is calling createDirectory when another node is calling pathExists for the same directory.

      When following the BackupRepository API Spec correctly, this should not be an issue because createDirectory should be a no-op when the directory already exists. However GCSRepository does not make this check before creating the directory. This should be an easy fix.

      Attachments

        Issue Links

          Activity

            People

              houston Houston Putman
              houston Houston Putman
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m