Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 9.0, 8.11
    • None
    • None

    Description

      There's currently no SolrJ support for the /admin/configs?action=UPLOAD API

      The workaround is to use a ContentStreamUpdateRequest and set the appropriate path and params

      Attachments

        1. SOLR-15708.patch
          20 kB
          Chris M. Hostetter
        2. SOLR-15708.patch
          20 kB
          Chris M. Hostetter

        Activity

          Attaching patch with proposed additions to SolrJ's ConfigSetAdminRequest and changes to existing tests to exercise the new solrj code.

          I think this is good to go, and should be safe to backport for an 8.11?

          hossman Chris M. Hostetter added a comment - Attaching patch with proposed additions to SolrJ's ConfigSetAdminRequest and changes to existing tests to exercise the new solrj code. I think this is good to go, and should be safe to backport for an 8.11?

          This looks good overall. A couple minor nits:

          • there's ModifiableParams.setNonNull that we can use instead of explicit if-s, makes the code cleaner.
          • I prefer using something == null instead of null == something as it feels more natural to me, and I think this is also prevalent in Solr code.
          ab Andrzej Bialecki added a comment - This looks good overall. A couple minor nits: there's ModifiableParams.setNonNull that we can use instead of explicit if-s, makes the code cleaner. I prefer using something == null instead of null == something as it feels more natural to me, and I think this is also prevalent in Solr code.

          there's ModifiableParams.setNonNull that

          Nice! ... i wasn't aware of that.

          Patch updated to use setNonNUll instead of the if conditions, and to add more class level javadocs to both ConfigSetAdminRequest.Upload and ConfigSetAdminRequest.Create clarifying when to use each.

          hossman Chris M. Hostetter added a comment - there's ModifiableParams.setNonNull that Nice! ... i wasn't aware of that. Patch updated to use setNonNUll instead of the if conditions, and to add more class level javadocs to both ConfigSetAdminRequest.Upload and ConfigSetAdminRequest.Create clarifying when to use each.

          Commit 58527ba5fd45ab8b2238f23850d46c5e58497446 in solr's branch refs/heads/main from Chris M. Hostetter
          [ https://gitbox.apache.org/repos/asf?p=solr.git;h=58527ba ]

          SOLR-15708: SolrJ support for ConfigSet uploading

          jira-bot ASF subversion and git services added a comment - Commit 58527ba5fd45ab8b2238f23850d46c5e58497446 in solr's branch refs/heads/main from Chris M. Hostetter [ https://gitbox.apache.org/repos/asf?p=solr.git;h=58527ba ] SOLR-15708 : SolrJ support for ConfigSet uploading

          Commit ae0c25fac8b6d97510f39a7f47d9dd5310a9938f in lucene-solr's branch refs/heads/branch_8x from Chris M. Hostetter
          [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ae0c25f ]

          SOLR-15708: SolrJ support for ConfigSet uploading

          (cherry picked from commit 58527ba5fd45ab8b2238f23850d46c5e58497446)

          jira-bot ASF subversion and git services added a comment - Commit ae0c25fac8b6d97510f39a7f47d9dd5310a9938f in lucene-solr's branch refs/heads/branch_8x from Chris M. Hostetter [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ae0c25f ] SOLR-15708 : SolrJ support for ConfigSet uploading (cherry picked from commit 58527ba5fd45ab8b2238f23850d46c5e58497446)
          jpountz Adrien Grand added a comment -

          Closing after the 8.11 release

          jpountz Adrien Grand added a comment - Closing after the 8.11 release

          People

            hossman Chris M. Hostetter
            hossman Chris M. Hostetter
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: