[SOLR-15462] Dubious code in DistribPackageStore::refresh

• Type: Task
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: Package Manager
• Labels: newdev
• Assignee: Unassigned
• Reporter: Mike Drob
• Created: 08/Jun/21 17:12
• Updated: 11/Oct/22 03:38

Description

The code in DistribPackageStore::refresh is slightly dubious. Discovered while working on SOLR-15385...

    @SuppressWarnings({"rawtypes"})
    List l = null;

      l = coreContainer.getZkController().getZkClient().getChildren(ZK_PACKAGESTORE + path, null, true);

      @SuppressWarnings({"rawtypes"})
      List myFiles = list(path, s -> true);

      for (Object f : l) {
        // TODO: XXX DUBIOUS XXX
        // l should be a List<String> and myFiles should be a List<FileDetails>, so contains should always return false!
        if (!myFiles.contains(f)) {

This is concerning because if we have proper typing, then contains should always return false. Are we always downloading the files and improperly caching the results?