Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-14497 Migrate to the Solr TLP
  3. SOLR-15454

retain and explain Lucene commits in .git-blame-ignore-revs

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • None
    • 9.0
    • None
    • None

    Description

      Transferring the third part of dsmiley's https://github.com/apache/solr/pull/162#issuecomment-854778916 comment here for visibility and transparency:

      ... `/.git-blame-ignore-revs` The current contents of that file should be wiped clean because they are all Lucene commits. We inherited it from the split.


      I note that we also inherited https://github.com/apache/solr/blob/a827aaac2bc1cc86bf182592203ea8fc749d3318/help/git.txt#L27

      git config blame.ignoreRevsFile .git-blame-ignore-revs
      

      content i.e. nothing to be done there. https://www.git-scm.com/docs/git-config#Documentation/git-config.txt-blameignoreRevsFile has info on what the file is about, in case you (like me) haven't come across it before.

      Also I double-checked via

      for commit in $(grep -v '#' .git-blame-ignore-revs)
      do
        git show --name-only $commit
      done | grep -v ^"lucene/" | sort -u
      

      result inspection that indeed the file contents can be wiped clean i.e. its essentially all Lucene commits.

      Attachments

        Issue Links

          Activity

            People

              cpoerschke Christine Poerschke
              cpoerschke Christine Poerschke
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m