[SOLR-15156] child transformer's childFilter shouldn't do escaping

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 8.9
• Labels: NestedDocuments
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 15/Feb/21 04:56
• Updated: 23/Jun/21 13:42
• Resolved: 17/Feb/21 03:40

Description

The child doc transformer's childFilter supports both some special path syntax and a simple field:value query with built-in escaping, or some other query so long as it doesn't contain a colon. I think there should not have been escaping here in the first place, thus letting you express whatever interesting query you want like we do in most other places in Solr. Simple. It may mean the user has to escape characters like '/' but that's normal. In a Java String that has an embedded local-params for the child doc transformer, that winds up being four back-slashes. So be it. It may seem like we're trying to do the user a favor by escaping what we see but I think it's actually more confusing to reason about because it's inconsistent, and it's limiting by getting in the way of more interesting queries. Besides, there are other ways of constructing the query syntax that results in zero escaping like childFilter='{!field f=nest_path}/toppings' So that's longer but no escaping at least. Up to the user's prerogative.

This will break existing users who depend on the escaping, and so warrants being done in a major release.

Issue Links

• links to: GitHub Pull Request #2367