[SOLR-14846] Avoid use of Optional.ofNullable.orElse in the same line

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 9.0
• Assignee: Mike Drob
• Reporter: Mike Drob
• Created: 08/Sep/20 18:20
• Updated: 12/May/22 00:26
• Resolved: 09/Sep/20 15:49

Description

Optional was meant to be used in public APIs to convey to the caller that they really need to null-check, not as an internal class to avoid doing our own null checks. There are better methods in Objects for that if we want them.

See also Brian Goetz at JavaOne - https://youtu.be/MFzlgAuanU0?t=2719

Issue Links

• links to: GitHub Pull Request #1843