[SOLR-14420] Address AuthenticationPlugin TODO redeclare params as HttpServletRequest & HttpServletResponse

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 9.0
• Component/s: security
• Assignee: Mike Drob
• Reporter: Mike Drob
• Created: 20/Apr/20 22:47
• Updated: 12/May/22 00:26
• Resolved: 22/Apr/20 17:06

Description

This was noted in SOLR-11692 and then I think the surrounding code change more in SOLR-12290, but the TODO remained unaddressed. We can declare this as HttpServletRequest/Response and all of the usages still work. There are plenty of implementations where we just do a cast anyway, and don't even do instanced checks.

I noticed this change for an external auth plugin that I'm working on that appears to have issues handling casts between ServletRequest and the CloseShield wrapper classes.

Issue Links

• links to: #1442