[SOLR-14370] Refactor bin/solr to allow external override of Jetty modules

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Abandoned
• Component/s: scripts and tools
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Andy Throgmorton
• Created: 28/Mar/20 00:01
• Updated: 26/Aug/24 19:01
• Resolved: 26/Aug/24 19:01

Description

The bin/solr script currently does not allow for externally overriding the modules passed to Jetty on startup.

This PR adds the ability to override the Jetty modules on startup by setting JETTY_MODULES as an environment variable; when passed, bin/solr will pass through (and not clobber) the string verbatim into SOLR_JETTY_CONFIG. For example, you can now run:

JETTY_MODULES=--module=foo bin/solr start

We've added some custom Jetty modules that can be optionally enabled; this change allows us to keep our logic (regarding which modules to use) in a separate script, rather than maintaining a forked bin/solr.

Issue Links

• links to: GitHub Pull Request #1385