[SOLR-14369] QueryContext (used only by facet module) should be removed

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: Facet Module
• Labels: refactoring
• Assignee: Unassigned
• Reporter: David Smiley
• Created: 27/Mar/20 17:49
• Updated: 27/May/20 18:04

Description

I was looking at QueryContext in org.apache.solr.search. It's only used by the JSON Facet module so I think it's in the wrong package although perhaps yonik intended to use it elsewhere. It's used frequently in the module to merely get a searcher, however FacetContext is always in scope and has a searcher likewise. It's used for close-hook management, but I think that can be propagated directly to SolrRequestInfo; basically merge that code directly with FacetContext. It's finally also used by FuncSlocAcc for ValueSource.getValues 1st arg (Map) but I think for that type of slot we can create such a Map on the fly.