[SOLR-14290] Fix NPE in SolrTestCaseJ4 breaking external usage for master/9.x

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 9.0
• Fix Version/s: 9.0
• Component/s: Tests

Environment

Solr Test Framework when run externally such that ExternalPaths.SOURCE_HOME is null

• Assignee: David Smiley
• Reporter: Gus Heck
• Created: 28/Feb/20 02:51
• Updated: 12/May/22 00:26
• Resolved: 10/Mar/22 20:15

Description

A fix for this was provided on branch_8x in SOLR-14283 but that same fix won't work in java 11 due to reflection restrictions that make it impossible (AFAIK) to un-final a final variable. We will likely need to employ powermock or our own java agent based solution, or redesign the way ExternalPaths.determinSourceHome and ExternalPaths.SOURCE_HOME work.

8.5 is coming up soon and we can't release with this broken in 8.5 so I'm separating the more complicated 9x fix into this ticket.

Issue Links

• is related to: SOLR-14283 Fix NPE in SolrTestCaseJ4 preventing it from working on external projects
• relates to: SOLR-14217 tests respect tests.workDir correctly (prevent SSD destruction)
• links to: GitHub Pull Request #739