[SOLR-14180] RequestHandlerBase.java:227 assertion failing: not all "Tragic" exceptions have 500 status, assert masks real failure

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: Chris M. Hostetter
• Created: 08/Jan/20 18:33
• Updated: 21/Jan/20 16:58

Description

RequestHandlerBase.java currently contains the following code added by SOLR-12477 ...

    } catch (Exception e) {
      if (req.getCore() != null) {
        boolean isTragic = req.getCore().getCoreContainer().checkTragicException(req.getCore());
        if (isTragic) {
          if (e instanceof SolrException) {
            // Tragic exceptions should always throw a server error
            assert ((SolrException) e).code() == 500;
          } else {
            // wrap it in a solr exception
            e = new SolrException(SolrException.ErrorCode.SERVER_ERROR, e.getMessage(), e);
          }
        }
      }

...however recent test failures have surfaced situations where this is evidnetly not true, and instead of the "original" error being returned to clients, the assertion fails, masking the "real" failure.

Issue Links

• is broken by: SOLR-12477 Return server error(500) for AlreadyClosedException instead of client Errors(400)
• relates to: SOLR-14179 BasicDistributedZkTest reproducible jenkins failure due to exceeding file handle limit