Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-1406

Refactor FileDataSource and FileListEntityProcessor to be more extensible

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: 1.4
    • Labels:
      None

      Description

      FileDataSource should make openStream method protected so we can extend FileDataSource for other File types such as GZip, by controlling the underlying InputStreamReader implementation being returned.

      FileListEntityProcessor needs to aggregate a list of files that were processed and expose that list in an accessible way so that further processing on that file list can be done in the close method. For example, deletion or archiving.

      Another improvement would be that in the event of an indexing rollback event, processing of the close method either does not occur, or the close method is allowed access to that event, to prevent processing within the close method if necessary.

        Attachments

        1. ASF.LICENSE.NOT.GRANTED--image.gif
          3 kB
          Luke Forehand
        2. SOLR-1406.patch
          13 kB
          Shalin Shekhar Mangar
        3. SOLR-1406.patch
          6 kB
          Shalin Shekhar Mangar
        4. SOLR-1406.patch
          2 kB
          Luke Forehand

          Activity

            People

            • Assignee:
              shalinmangar Shalin Shekhar Mangar
              Reporter:
              lukeforehand Luke Forehand
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: