[SOLR-14000] clean up more static field leaks in tests

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 8.4
• Assignee: Robert Muir
• Reporter: Robert Muir
• Created: 03/Dec/19 21:16
• Updated: 21/Jan/20 16:56
• Resolved: 03/Dec/19 23:57

Description

See build https://jenkins.thetaphi.de/job/Lucene-Solr-8.x-Windows/577/ for example, stuff like this:

Stack Trace:
junit.framework.AssertionFailedError: Clean up static fields (in @AfterClass?) and null them, your test still has references to classes of which the sizes cannot be measured due to security restrictions or Java 9 module encapsulation:
  - private static org.apache.solr.prometheus.scraper.SolrStandaloneScraper org.apache.solr.prometheus.scraper.SolrStandaloneScraperTest.solrScraper
  - private static org.apache.solr.client.solrj.impl.HttpSolrClient org.apache.solr.prometheus.scraper.SolrStandaloneScraperTest.solrClient

Looks like security manager issue, but its not, its just static leaks in tests. Its just that the thing they leak can't be inspected to see how "big" the leak is (apparently the objects were below some threshold before).

We should just plug the leaks, null them out in AfterClass.

Issue Links

• is related to: SOLR-13991 clean up permissions in solr-tests.policy
• is related to: SOLR-14002 fix more test static leaks (continued)
• is related to: SOLR-14033 Fix Hadoop tests with security manager