Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-13671

Remove check for bare "var" declarations in validate-source-patterns in before releasing Solr 9.0

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • None
    • 9.0
    • None
    • None

    Description

      See the discussion in the linked JIRA.

      Remove the line:

      (~$/\n\s*var\s+/$) : 'var is not allowed in until we stop development on the 8x code line'

      in

      invalidJavaOnlyPatterns

      from lucene/tools/src/groovy/check-source-patterns.groovy

      Attachments

        1. SOLR-13671.patch
          0.9 kB
          Alex Bulygin

        Issue Links

          Is contained by

          Wish - General wishlist item. SOLR-13658 Precommit fail Java "var" until 9x. Fail "var...<>" constructs entirely

          • Major - Major loss of function.
          • Resolved
          relates to

          Wish - General wishlist item. LUCENE-10136 Lift the restriction on using 'var' variables

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Closed
          links to

          Web Link GitHub Pull Request #366

          Activity

            People

              janhoy Jan Høydahl
              erickerickson Erick Erickson
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h