Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-13634

ResponseBuilderTest should be in same package as ReponseBuilder

Details

    • Task
    • Status: Resolved
    • Trivial
    • Resolution: Done
    • 8.1.1
    • 8.3
    • Server
    • None

    Description

      While playing around with the analytics package, I noticed ResponseBuilder is in Java package org.apache.solr.handler.component, whereas ResponseBuilderTest is in org.apache.solr.handler.  We should make them consistent.  I'll send a patch to move ResponseBuilderTest into the same package as ResponsBuilder.

      Attachments

        1. SOLR-13634.patch
          1 kB
          Neal Sidhwaney

        Activity

          lucenesolrqa Lucene/Solr QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
                Prechecks
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
                master Compile Tests
          +1 compile 2m 15s master passed
                Patch Compile Tests
          +1 compile 2m 1s the patch passed
          +1 javac 2m 1s the patch passed
          +1 Release audit (RAT) 2m 1s the patch passed
          +1 Check forbidden APIs 2m 1s the patch passed
          +1 Validate source patterns 2m 1s the patch passed
                Other Tests
          +1 unit 32m 58s core in the patch passed.
          40m 8s



          Subsystem Report/Notes
          JIRA Issue SOLR-13634
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12974669/SOLR-13634.patch
          Optional Tests compile javac unit ratsources checkforbiddenapis validatesourcepatterns
          uname Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
          Build tool ant
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
          git revision master / c97551c
          ant version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018
          Default Java LTS
          Test Results https://builds.apache.org/job/PreCommit-SOLR-Build/491/testReport/
          modules C: solr/core U: solr/core
          Console output https://builds.apache.org/job/PreCommit-SOLR-Build/491/console
          Powered by Apache Yetus 0.7.0 http://yetus.apache.org

          This message was automatically generated.

          lucenesolrqa Lucene/Solr QA added a comment - +1 overall Vote Subsystem Runtime Comment       Prechecks +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       master Compile Tests +1 compile 2m 15s master passed       Patch Compile Tests +1 compile 2m 1s the patch passed +1 javac 2m 1s the patch passed +1 Release audit (RAT) 2m 1s the patch passed +1 Check forbidden APIs 2m 1s the patch passed +1 Validate source patterns 2m 1s the patch passed       Other Tests +1 unit 32m 58s core in the patch passed. 40m 8s Subsystem Report/Notes JIRA Issue SOLR-13634 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12974669/SOLR-13634.patch Optional Tests compile javac unit ratsources checkforbiddenapis validatesourcepatterns uname Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux Build tool ant Personality /home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh git revision master / c97551c ant version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 Default Java LTS Test Results https://builds.apache.org/job/PreCommit-SOLR-Build/491/testReport/ modules C: solr/core U: solr/core Console output https://builds.apache.org/job/PreCommit-SOLR-Build/491/console Powered by Apache Yetus 0.7.0 http://yetus.apache.org This message was automatically generated.

          Commit 4b75776f5a7962200ae55f0125625890bf7ed1bd in lucene-solr's branch refs/heads/master from Munendra S N
          [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=4b75776 ]

          SOLR-13634:move ResponseBuilderTest to same package as ResponseBuilder

          jira-bot ASF subversion and git services added a comment - Commit 4b75776f5a7962200ae55f0125625890bf7ed1bd in lucene-solr's branch refs/heads/master from Munendra S N [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=4b75776 ] SOLR-13634 :move ResponseBuilderTest to same package as ResponseBuilder

          Commit 6899e0520ed3365be50c69a1b2c5f18d9624751b in lucene-solr's branch refs/heads/branch_8x from Munendra S N
          [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=6899e05 ]

          SOLR-13634:move ResponseBuilderTest to same package as ResponseBuilder

          jira-bot ASF subversion and git services added a comment - Commit 6899e0520ed3365be50c69a1b2c5f18d9624751b in lucene-solr's branch refs/heads/branch_8x from Munendra S N [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=6899e05 ] SOLR-13634 :move ResponseBuilderTest to same package as ResponseBuilder
          munendrasn Munendra S N added a comment -
          munendrasn Munendra S N added a comment - Thanks nealsidhwaney

          People

            munendrasn Munendra S N
            nealsidhwaney Neal Sidhwaney
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: