[SOLR-13337] TermsComponent sharded and terms.sort=index performance

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 7.7
• Fix Version/s: 8.1, 9.0
• Component/s: SearchComponents - other

Environment

Linux 64bit debian

20-node cluster

• Assignee: Mikhail Khludnev
• Reporter: Morten Bøgeskov
• Created: 20/Mar/19 06:18
• Updated: 12/May/22 00:26
• Resolved: 23/Apr/19 06:15

Description

When the TermsComponet distributes across all shards, all (terms.limit=-1) are returned.

This ought not to be needed when using terms.sort=index.

When using terms.lower=a in small test base (400k entries) it took 8.5-11.5s to do a

/terms?terms.fl=register&terms.sort=index&terms.lower=a I did not try it on production data (10x)

I do get the reason for getting all terms when sorting by count, however when sorting by index, no more than the terms.limit number rows is required from any shard. Most likely some will get discarded due to presence in more than one shard. Given no term.min/maxcount (which definetely throws a spanner in the works).

 

I've attached what I think would do the trick.

I haven't actually tested the patch (it compiles, however some other files in the checkout I have doesn't: ant compile, javac: "error: cannot find symbol")

 

Might be somewhat related issue (SOLR-2908). I didn't quite get the more subtle information in it.

 

 

Tested by

• applying patch to 7.7.1 (the one we use in production)
• start up on spare server (during off house on test system)
• add a replica from a collection (so that it'll serve requests)
• request /terms?terms.fl=phrase.title&terms.sort=index&terms.lower=a from the instance ~30 ms
• request the same from another unpatched instance ~17k ms
• both returned same result
• added terms.mincount=2 to the quick request. failed with out of memory
• restarted sever with more memory (.5g -> 8g)
• request completed in ~18k ms

 

I don't see how I'm supposed to unit test the functionality given it requires a cloud instance and sufficient data to give measurable difference with or without extra request arguments.

 

Issue Links

• duplicates: SOLR-12914 Solr crashes in /terms request handler
• relates to: SOLR-2908 To push the terms.limit parameter from the master core to all the shard cores.