Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-13322 Enable checking for System.out references in Solr codebase
  3. SOLR-13323

Remove org.apache.solr.internal.csv.writer.CSVWriter (and related classes)

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 9.0
    • 8.1, 9.0
    • None
    • None

    Description

      This class appears to only be used in the test for itself. It's also easily confused with org.apache.solr.response.CSVWriter

      I propose we remove this class entirely. Is there any reason to believe from it's past history (of which I know nothing) that it might be depended upon by outside code and require a deprecation cycle?

      Presently it contains a System.out.println and a eclipse generated catch block that precommit won't like if we enable checking for System.out.println, which is why this ticket is a sub-task. If we do need to deprecate it then I propose we remove the print and simply re-throw the exception as a RuntimeException

      Attachments

        Activity

          People

            Unassigned Unassigned
            gus Gus Heck
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: