[SOLR-13280] strengthen ScheduledTrigger's preferredOperation parameter validation

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 8.2, 9.0
• Component/s: AutoScaling
• Assignee: Christine Poerschke
• Reporter: Christine Poerschke
• Created: 27/Feb/19 21:32
• Updated: 26/Jul/19 08:56
• Resolved: 28/Jun/19 18:15

Description

Currently a typo such as (say) MOVE_REPLICA instead of the correct MOVEREPLICA results in a "success" response for the "set-trigger" call but in the Solr logs NullPointerException stuff is happening e.g.

  "eventType":"SCHEDULED",
  "properties":{
    "actualEventTime":...,
    "preferredOperation":"MOVE_REPLICA",
    "_enqueue_time_":...}}
        at org.apache.solr.cloud.autoscaling.ComputePlanAction.process(ComputePlanAction.java:160) ~[?:?]
        at org.apache.solr.cloud.autoscaling.ScheduledTriggers.lambda$null$3(ScheduledTriggers.java:324) ~[?:?]
        ... 6 more
Caused by: java.lang.NullPointerException
        at org.apache.solr.client.solrj.cloud.autoscaling.Policy$Session.getSuggester(Policy.java:628) ~[?:?]
        at org.apache.solr.cloud.autoscaling.ComputePlanAction.getSuggester(ComputePlanAction.java:262) ~[?:?]
        at org.apache.solr.cloud.autoscaling.ComputePlanAction.process(ComputePlanAction.java:97) ~[?:?]
        at org.apache.solr.cloud.autoscaling.ScheduledTriggers.lambda$null$3(ScheduledTriggers.java:324) ~[?:?]
        ... 6 more

Proposed patch to follow.