Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-13264

IndexSizeTrigger aboveOp / belowOp properties not in valid properties

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 8.6
    • Component/s: AutoScaling
    • Labels:
      None

      Description

      Steps to reproduce:

      ./bin/solr start -cloud -noprompt
      
      ./bin/solr create -c demo -d _default -shards 1 -replicationFactor 1
      
      curl "http://localhost:8983/solr/admin/autoscaling" -d'
      {
        "set-trigger" : {
          "name" : "index_size_trigger",
          "event" : "indexSize",
          "aboveDocs" : 12345,
          "aboveOp" : "SPLITSHARD",
          "enabled" : true,
          "actions" : [
            {
              "name" : "compute_plan",
              "class": "solr.ComputePlanAction"
            }
          ]
        }
      }
      '
      
      ./bin/solr stop -all
      

      The aboveOp is documented on https://lucene.apache.org/solr/guide/7_6/solrcloud-autoscaling-triggers.html#index-size-trigger and logically should be accepted (even though it is actually the default) but unexpectedly an error message is returned "Error validating trigger config index_size_trigger: TriggerValidationException{name=index_size_trigger, details='{aboveOp=unknown property}'}".

      From a quick look it seems that in the IndexSizeTrigger constructor additional values need to be passed to the TriggerUtils.validProperties method i.e. aboveOp, belowOp and maybe others too i.e. aboveSize/belowSize/etc. Illustrative patch to follow. Thank you.

        Attachments

        1. SOLR-13264.patch
          3 kB
          Christine Poerschke
        2. SOLR-13264.patch
          0.8 kB
          Christine Poerschke

          Activity

            People

            • Assignee:
              ab Andrzej Bialecki
              Reporter:
              cpoerschke Christine Poerschke
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: