[SOLR-13205] StringIndexOutOfBoundsException in SolrQueryParserBase.getFieldQuery

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 9.0
• Fix Version/s: 8.7, 9.0
• Component/s: search
• Labels: diffblue newdev

Environment

Steps to reproduce

• Use a Linux machine.
• Build commit ea2c8ba of Solr as described in the section below.
• Build the films collection as described below.
• Start the server using the command ./bin/solr start -f -p 8983 -s /tmp/home
• Request the URL given in the bug description.

Compiling the server

git clone https://github.com/apache/lucene-solr
cd lucene-solr
git checkout ea2c8ba
ant compile
cd solr
ant server

Building the collection and reproducing the bug

We followed Exercise 2 from the Solr Tutorial.

mkdir -p /tmp/home
echo '<?xml version="1.0" encoding="UTF-8" ?><solr></solr>' > /tmp/home/solr.xml

In one terminal start a Solr instance in foreground:

./bin/solr start -f -p 8983 -s /tmp/home

In another terminal, create a collection of movies, with no shards and no replication, and initialize it:

bin/solr create -c films
curl -X POST -H 'Content-type:application/json' --data-binary '{"add-field": {"name":"name", "type":"text_general", "multiValued":false, "stored":true}}' http://localhost:8983/solr/films/schema
curl -X POST -H 'Content-type:application/json' --data-binary '{"add-copy-field" : {"source":"*","dest":"_text_"}}' http://localhost:8983/solr/films/schema
./bin/post -c films example/films/films.json
curl -v “URL_BUG”

Please check the issue description below to find the “URL_BUG” that will allow you to reproduce the issue reported.

• Assignee: Jason Gerlowski
• Reporter: Johannes Kloos
• Created: 31/Jan/19 13:48
• Updated: 04/Nov/20 15:22
• Resolved: 29/Jul/20 14:42

Description

Requesting the following URL causes Solr to return an HTTP 500 error response:

http://localhost:8983/solr/films/select?df=&explainOther=debug=all&debugQuery=on

The error response seems to be caused by the following uncaught exception:

java.lang.StringIndexOutOfBoundsException: String index out of range: 0
at java.lang.String.charAt(String.java:658)
at org.apache.solr.parser.SolrQueryParserBase.getFieldQuery(SolrQueryParserBase.java:1045)
at org.apache.solr.parser.SolrQueryParserBase.handleBareTokenQuery(SolrQueryParserBase.java:801)
at org.apache.solr.parser.QueryParser.Term(QueryParser.java:421)
at org.apache.solr.parser.QueryParser.Clause(QueryParser.java:278)
at org.apache.solr.parser.QueryParser.Query(QueryParser.java:162)
at org.apache.solr.parser.QueryParser.TopLevelQuery(QueryParser.java:131)
at org.apache.solr.parser.SolrQueryParserBase.parse(SolrQueryParserBase.java:255)
at org.apache.solr.search.LuceneQParser.parse(LuceneQParser.java:49)
at org.apache.solr.search.QParser.getQuery(QParser.java:173)
at org.apache.solr.util.SolrPluginUtils.doSimpleQuery(SolrPluginUtils.java:479)
at org.apache.solr.util.SolrPluginUtils.doStandardResultsDebug(SolrPluginUtils.java:390)
at org.apache.solr.util.SolrPluginUtils.doStandardDebug(SolrPluginUtils.java:343)
at org.apache.solr.handler.component.DebugComponent.process(DebugComponent.java:100)
at org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:306)
at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:199)

The “df” parameter means that we set the empty string as default field. Since we do not give a field in the query, the default field is substituted in getFieldQuery. We then check if the field starts with “_” by using charAt(0).

A trivial fix would be to replace field.charAt(0) == ‘’ with field.startsWith(“”).

To set up an environment to reproduce this bug, follow the description in the ‘Environment’ field.

We automatically found this issue and ~70 more like this using Diffblue Microservices Testing. Find more information on this fuzz testing campaign.

Issue Links

• links to: GitHub Pull Request #936