Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-13030

MetricsHistoryHandler appears to never be "close()ed" - causes thread leaks?

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      MetricsHistoryHandler implements Closeable and depends on it's close() method to shutdown a private ScheduledThreadPoolExecutor collectService as well as a private final SolrRrdBackendFactory factory (which maintains it's own private ScheduledThreadPoolExecutor but as far as i can tell nothing seems to every "close" this MetricsHistoryHandler on shutdown. after changes in 75b1831967982 which move this close() call to a ForkJoinPool in CoreContainer.shutdown() it seems to be leaking threads.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                markrmiller@gmail.com Mark Miller
                Reporter:
                hossman Hoss Man
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: