Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-13030

MetricsHistoryHandler appears to never be "close()ed" - causes thread leaks?

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 8.0
    • None
    • None

    Description

      MetricsHistoryHandler implements Closeable and depends on it's close() method to shutdown a private ScheduledThreadPoolExecutor collectService as well as a private final SolrRrdBackendFactory factory (which maintains it's own private ScheduledThreadPoolExecutor but as far as i can tell nothing seems to every "close" this MetricsHistoryHandler on shutdown. after changes in 75b1831967982 which move this close() call to a ForkJoinPool in CoreContainer.shutdown() it seems to be leaking threads.

      Attachments

        Issue Links

          contains

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-12883 Upgrade to Jetty 9.4.14

          • Blocker - Blocks development and/or testing work, production could not run
          • Closed
          is related to

          Sub-task - The sub-task of the issue SOLR-12932 ant test (without badapples=false) should pass easily for developers.

          • Major - Major loss of function.
          • Open

          Activity

            People

              markrmiller@gmail.com Mark Miller
              hossman Chris M. Hostetter
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: