[SOLR-12776] Setting of TMP in solr.cmd causes invisibility of Solr to JDK tools

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.0
• Fix Version/s: 7.6, 8.0
• Component/s: scripts and tools

Environment

Windows. Tested with Java 8u152 and Solr 6.3.0.

• Assignee: Erick Erickson
• Reporter: Petr Bodnar
• Created: 16/Sep/18 13:37
• Updated: 08/Jun/19 15:02
• Resolved: 24/Sep/18 04:47

Description

(issue firstly discussed in here: http://mail-archives.apache.org/mod_mbox/lucene-solr-user/201809.mbox/[e-mail]%3E)

Please notice the following lines added (among others) to "solr.cmd" by commit https://github.com/apache/lucene-solr/commit/b36c68b16e67ae701cefce052a4fdbaac88fb65c for https://issues.apache.org/jira/browse/SOLR-6833 about 4 years ago (v5.0):

set TMP=!SOLR_HOME:%EXAMPLE_DIR%=!
IF NOT "%TMP%"=="%SOLR_HOME%" (
  set "SOLR_LOGS_DIR=%SOLR_HOME%\..\logs"
  set "LOG4J_CONFIG=file:%EXAMPLE_DIR%\resources\log4j.properties"
)

Apparently, the new variable "TMP" is just a temporary one, but by coincidence, this variable is also important for JVM. As this system variable tells where the "hsperfdata_<username>" directory for storing applications' monitoring data should be located. And if this is changed, JDK tools like JVisualVM, jps and others won't locally see the given Java application, because they search in a different default location.

Proposed solution

A working solution seems to be just to rename the TMP variable to for example TMP1 as in the attached simple-rename-fix.patch. Maybe even a simple "==" comparison of SOLR_HOME and EXAMPLE_DIR could (should?) be made, but I don't have enough time to study and test this scenario.