Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-12708

Async collection actions should not hide failures

    XMLWordPrintableJSON

    Details

      Description

      Async collection API may hide failures compared to sync version. OverseerCollectionMessageHandler::processResponses structures errors differently in the response, that hides failures from most evaluators. RestoreCmd did not receive, nor handle async addReplica issues.

      Sample create collection sync and async result with invalid solrconfig.xml:

      {
      "responseHeader":{
      "status":0,
      "QTime":32104},
      "failure":{
      "localhost:8983_solr":"org.apache.solr.client.solrj.impl.HttpSolrClient$RemoteSolrException:Error from server at http://localhost:8983/solr: Error CREATEing SolrCore 'name4_shard1_replica_n1': Unable to create core [name4_shard1_replica_n1] Caused by: The content of elements must consist of well-formed character data or markup.",
      "localhost:8983_solr":"org.apache.solr.client.solrj.impl.HttpSolrClient$RemoteSolrException:Error from server at http://localhost:8983/solr: Error CREATEing SolrCore 'name4_shard2_replica_n2': Unable to create core [name4_shard2_replica_n2] Caused by: The content of elements must consist of well-formed character data or markup.",
      "localhost:8983_solr":"org.apache.solr.client.solrj.impl.HttpSolrClient$RemoteSolrException:Error from server at http://localhost:8983/solr: Error CREATEing SolrCore 'name4_shard1_replica_n2': Unable to create core [name4_shard1_replica_n2] Caused by: The content of elements must consist of well-formed character data or markup.",
      "localhost:8983_solr":"org.apache.solr.client.solrj.impl.HttpSolrClient$RemoteSolrException:Error from server at http://localhost:8983/solr: Error CREATEing SolrCore 'name4_shard2_replica_n1': Unable to create core [name4_shard2_replica_n1] Caused by: The content of elements must consist of well-formed character data or markup."}
      }
      

      vs async:

      {
      "responseHeader":{
      "status":0,
      "QTime":3},
      "success":{
      "localhost:8983_solr":{
      "responseHeader":{
      "status":0,
      "QTime":12}},
      "localhost:8983_solr":{
      "responseHeader":{
      "status":0,
      "QTime":3}},
      "localhost:8983_solr":{
      "responseHeader":{
      "status":0,
      "QTime":11}},
      "localhost:8983_solr":{
      "responseHeader":{
      "status":0,
      "QTime":12}}},
      "myTaskId2709146382836":{
      "responseHeader":{
      "status":0,
      "QTime":1},
      "STATUS":"failed",
      "Response":"Error CREATEing SolrCore 'name_shard2_replica_n2': Unable to create core [name_shard2_replica_n2] Caused by: The content of elements must consist of well-formed character data or markup."},
      "status":{
      "state":"completed",
      "msg":"found [myTaskId] in completed tasks"}}
      

      Proposing adding failure node to the results, keeping backward compatible but correct result.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                tflobbe Tomas Eduardo Fernandez Lobbe
                Reporter:
                manokovacs Mano Kovacs
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 50m
                  50m