Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-1244

JdbcDataSource uses wrong overload of getConnection on JNDI DataSource

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 1.4
        • Fix Version/s: 1.4
        • Component/s: contrib - DataImportHandler
        • Labels:
          None
        • Environment:

          Any.

          Description

          When configured to use a JDBC DataSource via JNDI, JdbcDataSource checks to see if initProps contains a property named "user." If that property is null, DataSource.getConnection(String user, String password) is used where DataSource.getConnection() should be called. I will provide a test case and patch that fixes the issue.

          1. Text File
            SOLR-1244.patch
            8 kB
            Noble Paul
          2. Text File
            SOLR-1244.patch
            9 kB
            Chris Eldredge

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            chris.eldredge Chris Eldredge added a comment -

            Patch against r788203 including unit tests.

            Show
            chris.eldredge Chris Eldredge added a comment - Patch against r788203 including unit tests.
            Hide
            Permalink
            noble.paul Noble Paul added a comment -

            synced w/ trunk . I shall commit this shortly

            Show
            noble.paul Noble Paul added a comment - synced w/ trunk . I shall commit this shortly
            Hide
            Permalink
            noble.paul Noble Paul added a comment - - edited

            committed r788265

            thanks Chris

            Show
            noble.paul Noble Paul added a comment - - edited committed r788265 thanks Chris
            Hide
            Permalink
            gsingers Grant Ingersoll added a comment -

            Bulk close for Solr 1.4

            Show
            gsingers Grant Ingersoll added a comment - Bulk close for Solr 1.4

              People

              • Assignee:
                noble.paul Noble Paul
                Reporter:
                chris.eldredge Chris Eldredge
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development